Rename Observer to ValueObserver#764
Merged
codeboten merged 16 commits intoopen-telemetry:masterfrom Jun 8, 2020
Merged
Conversation
c24t
approved these changes
Jun 2, 2020
Member
|
See also #761. |
aabmass
reviewed
Jun 2, 2020
lzchen
added
metrics
api
6 tasks
codeboten
suggested changes
Jun 8, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Minor change requested in the changelog, otherwise this looks good!
codeboten
approved these changes
Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of [#753].
Name change.
ValueObservers are an API element, so default implementations were made for them in the API.