Rename CounterAggregator -> SumAggregator#816
Merged
toumorokoshi merged 4 commits intoopen-telemetry:masterfrom Jun 15, 2020
Merged
Rename CounterAggregator -> SumAggregator#816toumorokoshi merged 4 commits intoopen-telemetry:masterfrom
toumorokoshi merged 4 commits intoopen-telemetry:masterfrom
Conversation
lzchen
approved these changes
Jun 11, 2020
Contributor
lzchen
left a comment
lzchen
left a comment
There was a problem hiding this comment.
Might need an entry in CHANGELOG for sdk.
toumorokoshi
suggested changes
Jun 13, 2020
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
The code LGTM! Once there's a changelog entry I can approve.
Member
Author
|
Added an entry to the changelog |
codeboten
approved these changes
Jun 15, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Nice! Thanks for the contrib
toumorokoshi
approved these changes
Jun 15, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* feat: use context-based tracing * chore: use withSpan where possible * chore: propagate context in tests * chore: allow spanoptions to override parent from context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #796 as requested by @lzchen. I also renamed a few variables names from
counter*->sum_agg*.