Script to regenerate proto code + pyi stubs#823
Script to regenerate proto code + pyi stubs#823lzchen merged 17 commits intoopen-telemetry:masterfrom
Conversation
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Change looks good, it looks like the protos were regenerated as part of the change, if so it would be good to updated the changelog for it.
ocelotl
left a comment
ocelotl
left a comment
There was a problem hiding this comment.
Looking great, it would be great to merge this into the tox directive for opentelemetry-proto.
As discussed in the SIG meeting, added a const PROTO_REPO_BRANCH_OR_COMMIT, a commit/branch/tag in opentelemetry-proto repo to build from. When you are ready to pull in changes from upstream proto defs, just update the const, rebuild, and fix errors in OTLP exporter.
|
As discussed in the SIG meeting, added a const |
@codeboten changelog updated |
5 participants
Closes #792, closes #793
scripts/proto_codegen.shto regenerate the python code from proto files in the opentelemetry-proto repo. It does a fresh pull (or clone if needed) each time you build so just run the script to get updates from the other repo. Let me know if the script should be in a different place..pyistub files. This gives type hints for the strange code the protoc generates so tooling and mypy can make sense of it..gitattributespattern for the generated code so you don't have to scroll through it (unless you want to 😄 )MANIFEST.inso it will pull in the pyi files.