Skip to content

add gco agent span label#833

Merged
lzchen merged 19 commits intoopen-telemetry:masterfrom
AndrewAXue:cloud_trace_gco
Jun 22, 2020
Merged

add gco agent span label#833
lzchen merged 19 commits intoopen-telemetry:masterfrom
AndrewAXue:cloud_trace_gco

Conversation

@AndrewAXue
Copy link
Copy Markdown
Contributor

No description provided.

@AndrewAXue AndrewAXue requested a review from a team June 16, 2020 21:50
Copy link
Copy Markdown
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits and questions, LGTM otherwise.

Copy link
Copy Markdown
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lzchen lzchen merged commit b2c0d53 into open-telemetry:master Jun 22, 2020
@AndrewAXue AndrewAXue deleted the cloud_trace_gco branch June 22, 2020 19:49
AndrewAXue pushed a commit to AndrewAXue/opentelemetry-python that referenced this pull request Jun 22, 2020
add uuid label to metricdescriptor
AndrewAXue pushed a commit to AndrewAXue/opentelemetry-python that referenced this pull request Jun 22, 2020
add uuid label to metricdescriptor
cnnradams pushed a commit to cnnradams/opentelemetry-python that referenced this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants