Skip to content

Fix requests version for Docker tests#844

Closed
ocelotl wants to merge 1 commit intoopen-telemetry:masterfrom
ocelotl:issue_843
Closed

Fix requests version for Docker tests#844
ocelotl wants to merge 1 commit intoopen-telemetry:masterfrom
ocelotl:issue_843

Conversation

@ocelotl
Copy link
Copy Markdown
Contributor

@ocelotl ocelotl commented Jun 18, 2020

Fixes #843

@ocelotl ocelotl requested a review from a team June 18, 2020 23:12
@ocelotl ocelotl self-assigned this Jun 18, 2020
@toumorokoshi
Copy link
Copy Markdown
Member

looks like CI is failing for this reason still? https://travis-ci.org/github/open-telemetry/opentelemetry-python/builds/699901297

@ocelotl
Copy link
Copy Markdown
Contributor Author

ocelotl commented Jun 19, 2020

looks like CI is failing for this reason still? https://travis-ci.org/github/open-telemetry/opentelemetry-python/builds/699901297

Yes, very weird. I ran locally with these changes and docker-tests passed, when I ran master locally without them it failed. I even negated the value of allow_redirects in the local virtual environment installation of requests 2.24.0 and docker-tests passed. I just ran docker-tests on master and all tests passed. Who knows, closing this PR.

@ocelotl ocelotl closed this Jun 19, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker test test_fn_task_delay is failing

2 participants