Fixing the serialization of a tuple element by coercing it into a string#865
Merged
toumorokoshi merged 4 commits intoopen-telemetry:masterfrom Jul 13, 2020
bitspradp:serialize_tuple_objects
Merged
Fixing the serialization of a tuple element by coercing it into a string#865toumorokoshi merged 4 commits intoopen-telemetry:masterfrom bitspradp:serialize_tuple_objects
toumorokoshi merged 4 commits intoopen-telemetry:masterfrom
bitspradp:serialize_tuple_objects
Conversation
Contributor
Author
|
The CI for this PR has failed because of the |
toumorokoshi
suggested changes
Jul 2, 2020
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
Quick comment on the change log, but looks good otherwise! Thanks for submitting.
|
|
||
| - Transform resource to tags when exporting | ||
| ([#645](https://github.com/open-telemetry/opentelemetry-python/pull/645)) | ||
| - ext/boto: Could not serialize attribute aws.region to tag when exporting via jaeger |
Member
There was a problem hiding this comment.
Would you mind changing this to be more descriptive of the change? I think the "why" is good too, but knowing precisely what the fix or behavioral change was will apply more broadly to those reading the changelog.
lzchen
approved these changes
Jul 2, 2020
toumorokoshi
approved these changes
Jul 13, 2020
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
Thanks for addressing the changelog!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #818
This PR aims at fix the serialization of tuple type values by coercing them into a string.
Tests make sure that this type is handled correctly. The current test is enhanced to include tuple type as well.