Rename exporter packages from "ext" to "exporter"#953
Merged
lzchen merged 16 commits intoopen-telemetry:masterfrom Jul 29, 2020
Merged
Rename exporter packages from "ext" to "exporter"#953lzchen merged 16 commits intoopen-telemetry:masterfrom
lzchen merged 16 commits intoopen-telemetry:masterfrom
Conversation
aabmass
approved these changes
Jul 28, 2020
Member
aabmass
left a comment
aabmass
left a comment
There was a problem hiding this comment.
LGTM! Could you actually just delete the cloud_{trace,monitoring}.rst files :)
lzchen
changed the title
codeboten
suggested changes
Jul 29, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
This looks good, just a question i'd like an answer to before moving to approve
| BASE_DIR = os.path.dirname(__file__) | ||
| VERSION_FILENAME = os.path.join( | ||
| BASE_DIR, "src", "opentelemetry", "ext", "jaeger", "version.py" | ||
| BASE_DIR, "src", "opentelemetry", "exporter", "datadog", "version.py" |
Contributor
There was a problem hiding this comment.
any idea what happened here? looks like theres a few instances of files being moved to different exporters in the PR
Contributor
Author
There was a problem hiding this comment.
I'm not sure what happened here. Maybe github has a weird way of tracking diffs? Anyways, the resulting files look correct and all the tests pass so the directories must be pointing to the right things.
codeboten
approved these changes
Jul 29, 2020
2 tasks
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* updating missing semi-colon * Updating semi-colon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of [#760]. Renaming just the exporters first to minimize mistakes.
Checklist:
readmes
setup files
generated docs
tox
changelogs