Move sampler to SDK.#257
Merged
SergeyKanzhelev merged 4 commits intoopen-telemetry:masterfrom Oct 3, 2019
Merged
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
requested review from
AloisReitbauer,
SergeyKanzhelev,
c24t,
carlosalberto,
iredelmeier,
reyang,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
songy23
reviewed
Sep 24, 2019
SergeyKanzhelev
approved these changes
Sep 26, 2019
Member
SergeyKanzhelev
left a comment
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
I agree in general. This doc is really missing some scenarios description. Also many minor suggestions
carlosalberto
approved these changes
Oct 1, 2019
Member
|
@bogdandrutu will you please update the branch and address suggestions. Do you need some help with it? |
SergeyKanzhelev
changed the title
Member
|
I removed any mentions of SamplingHint. As agreed with @bogdandrutu it will be handled in a separate PR |
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Move sampler to SDK and add SamplingHint. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Add link to sampling in the details section. * remove sampling hint and addressed PR feedback
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Move sampler to SDK and add SamplingHint. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Add link to sampling in the details section. * remove sampling hint and addressed PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part of updating specs based on https://github.com/open-telemetry/oteps/blob/master/text/0006-sampling.md:
What is left: