Cleanup markdown in sdk-tracing. No text changed.#266
Merged
SergeyKanzhelev merged 3 commits intoopen-telemetry:masterfrom Sep 27, 2019
Merged
Cleanup markdown in sdk-tracing. No text changed.#266SergeyKanzhelev merged 3 commits intoopen-telemetry:masterfrom
SergeyKanzhelev merged 3 commits intoopen-telemetry:masterfrom
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
requested review from
AloisReitbauer,
SergeyKanzhelev,
c24t,
carlosalberto,
iredelmeier,
reyang,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
tigrannajaryan
approved these changes
Sep 27, 2019
songy23
approved these changes
Sep 27, 2019
SergeyKanzhelev
approved these changes
Sep 27, 2019
Member
|
This looks like an uncontroversial change. Merging. Separate PR with integrating it into Circle CI is questionable for me. My understanding is that the agreement was that the line break is a soft requirement. But I wasn't at the time this discussion happened so please correct me |
Member
|
@SergeyKanzhelev Markdownlint check added in #268 is an optional check. |
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
TuckTuckFloof
pushed a commit
to TuckTuckFloof/opentelemetry-specification
that referenced
this pull request
Oct 15, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 23, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com