Add list of exporters that are recommended for SDK#284
Merged
bogdandrutu merged 2 commits intoopen-telemetry:masterfrom Oct 5, 2019
Merged
Conversation
Based on previous discussion [1] this PR adds a recommendation to include exporters for several open-source protocols in language libraries. Addresses issue open-telemetry#6 [1] - open-telemetry#277 (comment)
tigrannajaryan
requested review from
AloisReitbauer,
SergeyKanzhelev,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
songy23,
tedsuo and
yurishkuro
as code owners
songy23
approved these changes
Oct 3, 2019
yurishkuro
reviewed
Oct 3, 2019
| 5. Language library implementation should include an exporter for OpenTelemetry Protocol (when the protocol is specified and approved) and may include an exporter that writes to standard output (to use for debugging and testing). Vendor-specific exporters (exporters that implement vendor protocols) should not be included in language libraries and should be placed elsewhere (the exact approach for storing and maintaining vendor-specific exporters will be defined in the future). | ||
| 5. Language library implementation should include the following exporters: | ||
| - Jaeger. | ||
| - Zipkin. |
Member
There was a problem hiding this comment.
- Jaeger and Zipkin backends support multiple encodings and transports, e.g. thrift, json, proto, udp, http, grpc. Which makes this recommendation pretty broad. Is the SDK in each language expected to implement all of those? Or at minimum one of those?
- This recommendation only applies to OTel SDKs, not to any implementation of OTel API. Perhaps this file should be renamed and scoped differently, e.g.
sdk-guidelines.md
Member
Author
There was a problem hiding this comment.
@yurishkuro I added a note that exact list of protocol is to be defined and also replaced "language library" by "SDK" in a few relevant places.
I think we should keep the name of the file since it is not only about SDK but touches the API package as well.
tedsuo
approved these changes
Oct 4, 2019
Contributor
tedsuo
left a comment
tedsuo
left a comment
There was a problem hiding this comment.
I recommend that we merge this for now, then follow up later to discuss the clarifications that @yurishkuro suggests.
tigrannajaryan
force-pushed
the
feature/tigran/standardexporters
branch
2 times, most recently
from
eefc47d to
10e99f8
Compare
yurishkuro
approved these changes
Oct 4, 2019
Member
Author
|
Admins: for some reason I cannot merge PRs in this spec. I guess I should be able as an approver? If so please give the merge permission. |
c24t
approved these changes
Oct 4, 2019
carlosalberto
approved these changes
Oct 4, 2019
Contributor
|
I recommend that after merging we also include an In Memory exporter option, as this will help users write tests (we had something like this in OT, called |
Member
|
@tigrannajaryan do you want to add "in memory" next to "Standard output (or logging)"? |
Member
Author
|
@yurishkuro @carlosalberto sure, let me add in-memory to the list. |
tigrannajaryan
force-pushed
the
feature/tigran/standardexporters
branch
from
10e99f8 to
1807572
Compare
Member
Author
|
@yurishkuro @carlosalberto "in-memory" exported added. |
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Add list of exporters that are recommended for SDK Based on previous discussion [1] this PR adds a recommendation to include exporters for several open-source protocols in language libraries. Addresses issue open-telemetry#6 [1] - open-telemetry#277 (comment) * PR fixes
TuckTuckFloof
pushed a commit
to TuckTuckFloof/opentelemetry-specification
that referenced
this pull request
Oct 15, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Add list of exporters that are recommended for SDK Based on previous discussion [1] this PR adds a recommendation to include exporters for several open-source protocols in language libraries. Addresses issue open-telemetry#6 [1] - open-telemetry#277 (comment) * PR fixes
schmikei
pushed a commit
to schmikei/opentelemetry-specification
that referenced
this pull request
Apr 17, 2025
…ing to OTEP 220 (open-telemetry#284) Co-authored-by: Liudmila Molkova <limolkova@microsoft.com> Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on previous discussion [1] this PR adds a recommendation to include
exporters for several open-source protocols in language libraries.
Fixes #6
[1] - #277 (comment)