Replace redirected urls with their targets#4557
Merged
carlosalberto merged 9 commits intoopen-telemetry:mainfrom Jun 16, 2025
Merged
Replace redirected urls with their targets#4557carlosalberto merged 9 commits intoopen-telemetry:mainfrom
carlosalberto merged 9 commits intoopen-telemetry:mainfrom
Conversation
trask
commented
Jun 13, 2025
trask
commented
Jun 13, 2025
trask
commented
Jun 13, 2025
trask
commented
Jun 13, 2025
lmolkova
approved these changes
Jun 13, 2025
Contributor
|
@trask - might it be useful to commit that helper script in one of the OTel repos? |
carlosalberto
approved these changes
Jun 13, 2025
Contributor
|
If so, @trask, please let me know where it lands. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
A last one after #4557
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to @chalin's #4554
We could enforce no redirects via lychee's
max_redirects = 0configuration, but we'd need to make a few exclusions for that to work, and it would only make our link check failures even more common as 3rd party sites move things around. Probably a better option to address @chalin's specific ask would be to have a separate lychee run withmax_redirects = 0that only checks https://opentelemetry.io links.Most of this was done using:
python script