env var propagation carrier as Getter and Setter#47
Open
pellared wants to merge 10 commits intoopen-telemetry:mainfrom
Open
env var propagation carrier as Getter and Setter#47pellared wants to merge 10 commits intoopen-telemetry:mainfrom
pellared wants to merge 10 commits intoopen-telemetry:mainfrom
Conversation
pellared
requested review from
ArielDemarco,
bryce-b,
nachoBonafonte and
vvydier
as code owners
pellared
commented
Mar 30, 2026
Member
Author
|
FYI @open-telemetry/semconv-cicd-approvers |
pellared
commented
Apr 3, 2026
…ingGetter key normalization
kamphaus
reviewed
Apr 11, 2026
kamphaus
approved these changes
Apr 11, 2026
adrielp
approved these changes
Apr 13, 2026
github-merge-queue bot
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Apr 13, 2026
… environment variables (#5003) Per #4961 (comment) and other similar feedback ## Changes This PR removes the non-normative guidance that presented a dedicated `EnvironmentContextPropagator` as a first-class alternative for environment variable context propagation. The supplementary guidance now describes the carrier-based pattern directly: - use the existing `TextMapPropagator` with environment-specific carriers (`EnvironmentGetter` and `EnvironmentSetter`) - reference the existing C++, Go, Java, and Python implementation (I also created a PR for Swift that follows the same pattern open-telemetry/opentelemetry-swift-core#47) The previous (removed) “Approach 1” guidance suggested that a dedicated environment-variable-specific propagator was a viable recommendation. Based on the discussion in #4961, that approach is seen as misleading/buggy: - the environment variable carrier should remain format-agnostic - propagator-specific behavior belongs in the propagator, not in the carrier - the Swift example did not reflect the direction we want to recommend here This change keeps the document aligned with the carrier-based model used by the referenced implementations. ## Side note I think we can look into stabilization of this document after this PR is merged. I plan to create a stabilization issue and update the compliance matrix. --------- Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per:
This makes the environment variable propagation carrier to be composable with any propagator.
This should also make the implementation spec-compliant as I also implemented the key normalization.
Related to:
Disclaimer, I confess that I have never written a single line of code in Swift. I used Copilot and experience from other languages.