fix: resolve Swift 6.2 sending violations in ActivityContextManagerTests#52
Merged
nachoBonafonte merged 1 commit intoopen-telemetry:mainfrom Apr 16, 2026
Merged
Conversation
Remove `nonisolated` from `createAsyncSpan` so it inherits `@MainActor` from the enclosing class. Swift 6.2 flags sending non-Sendable `Span` values to nonisolated async methods as a hard error, even with `-strict-concurrency=minimal`. Keeping the method on the main actor eliminates the isolation boundary. Also remove the outdated `#if compiler(>=5.10) #warning(...)` block.
gmoraleda
requested review from
ArielDemarco,
bryce-b,
nachoBonafonte and
vvydier
as code owners
nachoBonafonte
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nonisolatedfromcreateAsyncSpanso it inherits@MainActorfrom the enclosing test class#if compiler(>=5.10) #warning(...)blockSwift 6.2 (Xcode 26) treats
sendingdiagnostics as hard errors even with-strict-concurrency=minimal. Thenonisolated async func createAsyncSpancaused 18 errors because passing non-SendableSpanvalues from@MainActorTaskclosures to a nonisolated async method crosses an isolation boundary. Removingnonisolatedkeeps the method on the main actor, eliminating the boundary.Test plan
swift build --build-tests— 0 errors (was 18)swift test— 508 tests, 0 failures