update the examples to use the new OTEL_CONFIG_FILE variable#9340
update the examples to use the new OTEL_CONFIG_FILE variable#9340tiffany76 merged 16 commits intoopen-telemetry:mainfrom
Conversation
As the declarative config has stabilized, implementations will be updating the env variable supported from OTEL_EXPERIMENTAL_CONFIG_FILE to OTEL_CONFIG_FILE. The docs will need to reflect that as well. Signed-off-by: alex boten <[email protected]>
There was a problem hiding this comment.
Probably worth updating this to indicate that key parts and the spec and schema are stable, despite SDK components not yet publishing stable components
There was a problem hiding this comment.
Updated the warning to include additional details, PTAL
There was a problem hiding this comment.
Same here: https://github.com/open-telemetry/opentelemetry.io/pull/9340/changes#r2891360594
As of the next release of the java agent, the SDK portions of the schema will be stable. But the agent portions (.distribution and .instrumentation/development) are not yet stable.
Feel free to ignore this @codeboten since this is the responsibility of @open-telemetry/java-instrumentation-approvers / @open-telemetry/java-approvers.
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
|
Waiting on open-telemetry/opentelemetry-php#1900 to get resolved before marking this ready for reviews |
could we split the PR into a java and a PHP part and address them individually? |
|
/fix:format |
That was merged, this is good to go now |
|
✅ |
|
Pinging @open-telemetry/php-approvers @open-telemetry/java-approvers |
|
@open-telemetry/php-approvers and @open-telemetry/java-approvers, PTAL! |
Co-authored-by: Jay DeLuca <[email protected]>
|
/fix:format |
|
✅ |
As the declarative config has stabilized, implementations will be updating the env variable supported from
OTEL_EXPERIMENTAL_CONFIG_FILEtoOTEL_CONFIG_FILE. The docs will need to reflect that as well.This PR has content that I did not fully write myself.I used AI and I have read and followed the Generative AI Contribution Policy.NOTE: i'm leaving this in draft until i can confirm that the implementations (java/php) have updated their support
Footnotes
Yes, I can answer maintainer questions about the content of this PR, without using AI. ↩