Skip to content

update the examples to use the new OTEL_CONFIG_FILE variable#9340

Merged
tiffany76 merged 16 commits intoopen-telemetry:mainfrom
codeboten:codeboten/update-config-var
Apr 17, 2026
Merged

update the examples to use the new OTEL_CONFIG_FILE variable#9340
tiffany76 merged 16 commits intoopen-telemetry:mainfrom
codeboten:codeboten/update-config-var

Conversation

@codeboten
Copy link
Copy Markdown
Contributor

As the declarative config has stabilized, implementations will be updating the env variable supported from OTEL_EXPERIMENTAL_CONFIG_FILE to OTEL_CONFIG_FILE. The docs will need to reflect that as well.

  • I have read and followed the Contributing docs, especially the "First-time contributing?" section.
  • This PR has content that I did not fully write myself.
  • I have the experience and knowledge necessary to understand, review, and validate all content in this PR.1

NOTE: i'm leaving this in draft until i can confirm that the implementations (java/php) have updated their support

Footnotes

  1. Yes, I can answer maintainer questions about the content of this PR, without using AI.

As the declarative config has stabilized, implementations will be updating the env variable supported from OTEL_EXPERIMENTAL_CONFIG_FILE to OTEL_CONFIG_FILE. The docs will need to reflect that as well.

Signed-off-by: alex boten <[email protected]>
@otelbot-docs otelbot-docs bot requested review from a team March 5, 2026 17:33
@otelbot-docs otelbot-docs bot added missing:docs-approval Co-owning SIG has provided approval, PR needs approval from docs maintainer missing:sig-approval Co-owning SIG didn't provide an approval labels Mar 5, 2026
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth updating this to indicate that key parts and the spec and schema are stable, despite SDK components not yet publishing stable components

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the warning to include additional details, PTAL

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: https://github.com/open-telemetry/opentelemetry.io/pull/9340/changes#r2891360594

As of the next release of the java agent, the SDK portions of the schema will be stable. But the agent portions (.distribution and .instrumentation/development) are not yet stable.

Feel free to ignore this @codeboten since this is the responsibility of @open-telemetry/java-instrumentation-approvers / @open-telemetry/java-approvers.

Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
@otelbot-docs otelbot-docs bot requested review from a team March 5, 2026 18:30
@codeboten
Copy link
Copy Markdown
Contributor Author

Waiting on open-telemetry/opentelemetry-php#1900 to get resolved before marking this ready for reviews

@svrnm
Copy link
Copy Markdown
Member

svrnm commented Mar 16, 2026

Waiting on open-telemetry/opentelemetry-php#1900 to get resolved before marking this ready for reviews

could we split the PR into a java and a PHP part and address them individually?

@codeboten
Copy link
Copy Markdown
Contributor Author

/fix:format

@codeboten codeboten marked this pull request as ready for review March 28, 2026 08:22
@codeboten codeboten requested a review from a team as a code owner March 28, 2026 08:22
@codeboten
Copy link
Copy Markdown
Contributor Author

Waiting on open-telemetry/opentelemetry-php#1900 to get resolved before marking this ready for reviews

could we split the PR into a java and a PHP part and address them individually?

That was merged, this is good to go now

@otelbot-docs
Copy link
Copy Markdown
Contributor

otelbot-docs bot commented Mar 28, 2026

fix:format applied successfully in run 23681225333.

@otelbot-docs otelbot-docs bot removed the missing:docs-approval Co-owning SIG has provided approval, PR needs approval from docs maintainer label Mar 28, 2026
@codeboten
Copy link
Copy Markdown
Contributor Author

Pinging @open-telemetry/php-approvers @open-telemetry/java-approvers

@tiffany76
Copy link
Copy Markdown
Member

@open-telemetry/php-approvers and @open-telemetry/java-approvers, PTAL!

@otelbot-docs otelbot-docs bot added ready-to-be-merged This PR is ready to be merged by a maintainer and removed missing:sig-approval Co-owning SIG didn't provide an approval labels Apr 14, 2026
@otelbot-docs otelbot-docs bot requested a review from a team April 14, 2026 16:49
Comment thread content/en/docs/zero-code/java/agent/declarative-configuration.md Outdated
@otelbot-docs otelbot-docs bot requested a review from a team April 17, 2026 04:15
@jaydeluca
Copy link
Copy Markdown
Member

/fix:format

@otelbot-docs
Copy link
Copy Markdown
Contributor

otelbot-docs bot commented Apr 17, 2026

fix:format applied successfully in run 24559534230.

@otelbot-docs otelbot-docs bot requested a review from a team April 17, 2026 10:07
@tiffany76 tiffany76 added this pull request to the merge queue Apr 17, 2026
Merged via the queue into open-telemetry:main with commit da51d8e Apr 17, 2026
24 checks passed
@codeboten codeboten deleted the codeboten/update-config-var branch April 20, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-be-merged This PR is ready to be merged by a maintainer sig:java sig:php

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants