Skip to content

docs(demo): add tail-based sampling example using service.criticality#9468

Merged
tiffany76 merged 10 commits intoopen-telemetry:mainfrom
bachgarash:demo/add-sample-configurations-dir
Apr 13, 2026
Merged

docs(demo): add tail-based sampling example using service.criticality#9468
tiffany76 merged 10 commits intoopen-telemetry:mainfrom
bachgarash:demo/add-sample-configurations-dir

Conversation

@bachgarash
Copy link
Copy Markdown
Contributor

@bachgarash bachgarash commented Mar 21, 2026

This PR adds documentation for opentelemetry-demo which includes newly introduced semantic convention attribute service.criticality

Summary

  • Add a new "Sample Configurations" section under the demo docs
  • Document a tail-based sampling example using the service.criticality resource attribute introduced in SemConv 1.40.0
  • Include collector configuration with sampling policies based on service criticality levels (critical, high, medium, low)

Context

This documentation accompanies open-telemetry/opentelemetry-demo#2950, which adds service.criticality as a resource attribute to all demo services. The example was originally included in the
demo's otelcol-config-extras.yml and moved here per reviewer feedback.

semconv PR

  • I have read and followed the Contributing docs, especially the "First-time contributing?" section.
  • This PR has content that I did not fully write myself.
  • I have the experience and knowledge necessary to understand, review, and validate all content in this PR.1

Footnotes

  1. Yes, I can answer maintainer questions about the content of this PR, without using AI.

@bachgarash bachgarash requested a review from a team as a code owner March 21, 2026 09:03
@otelbot-docs otelbot-docs bot requested a review from a team March 21, 2026 09:03
@otelbot-docs otelbot-docs bot added missing:docs-approval Co-owning SIG has provided approval, PR needs approval from docs maintainer missing:sig-approval Co-owning SIG didn't provide an approval labels Mar 21, 2026
@theletterf
Copy link
Copy Markdown
Member

@open-telemetry/demo-maintainers Please have a look, thanks!

@bachgarash bachgarash force-pushed the demo/add-sample-configurations-dir branch from b766dc1 to 258b078 Compare April 8, 2026 11:15
@julianocosta89
Copy link
Copy Markdown
Member

LGTM and the service.criticality attribute was merged today.
This should be good to go

@otelbot-docs otelbot-docs bot removed the missing:sig-approval Co-owning SIG didn't provide an approval label Apr 9, 2026
@vitorvasc
Copy link
Copy Markdown
Member

/fix:format

@otelbot-docs
Copy link
Copy Markdown
Contributor

otelbot-docs bot commented Apr 9, 2026

fix:format applied successfully in run 24184692165.

@otelbot-docs otelbot-docs bot requested a review from a team April 9, 2026 10:13
Comment thread content/en/docs/demo/sample-configurations/_index.md Outdated
Comment thread content/en/docs/demo/sample-configurations/tail-sampling-service-criticality.md Outdated
Comment thread content/en/docs/demo/sample-configurations/_index.md Outdated
bachgarash and others added 7 commits April 9, 2026 15:15
  Add sample collector configuration demonstrating a better
  tail-based sampling policies based on the service.criticality
  resource attribute introduced in SemConv 1.40.0.

  Ref: open-telemetry/opentelemetry-demo#2950
@bachgarash bachgarash force-pushed the demo/add-sample-configurations-dir branch from 8411dfb to b5d10fb Compare April 9, 2026 12:15
@tiffany76
Copy link
Copy Markdown
Member

/fix

@otelbot-docs
Copy link
Copy Markdown
Contributor

otelbot-docs bot commented Apr 13, 2026

fix applied successfully in run 24360859702.

Copy link
Copy Markdown
Member

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a switch from ordered to unordered list. Thanks!

Comment thread content/en/docs/demo/sample-configurations/tail-sampling-service-criticality.md Outdated
@otelbot-docs otelbot-docs bot added ready-to-be-merged This PR is ready to be merged by a maintainer and removed missing:docs-approval Co-owning SIG has provided approval, PR needs approval from docs maintainer labels Apr 13, 2026
@tiffany76
Copy link
Copy Markdown
Member

/fix:format

@otelbot-docs
Copy link
Copy Markdown
Contributor

otelbot-docs bot commented Apr 13, 2026

fix:format applied successfully in run 24362084497.

@tiffany76 tiffany76 added this pull request to the merge queue Apr 13, 2026
Merged via the queue into open-telemetry:main with commit d503571 Apr 13, 2026
24 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot bot commented Apr 13, 2026

Thank you for your contribution @bachgarash! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

tiffany76 added a commit to tiffany76/opentelemetry.io that referenced this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-be-merged This PR is ready to be merged by a maintainer sig:demo

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants