Add prefer-blockquote-vs-docsy-alerts rule, apply rule to en pages, plus some copyedits#9659
Merged
chalin merged 3 commits intoopen-telemetry:mainfrom Apr 15, 2026
Conversation
chalin
commented
Apr 15, 2026
Comment on lines
+57
to
+70
| > [!IMPORTANT] Preserve parent tracestate | ||
| > | ||
| > In `ShouldSample`, you _must_ preserve the parent's tracestate in your | ||
| > `SamplingResult`. Failing to do so breaks context propagation in distributed | ||
| > systems that rely on tracestate for passing vendor-specific or | ||
| > application-specific trace data. | ||
| > | ||
| > Extract the tracestate from the parent span context: | ||
| > | ||
| > ```go | ||
| > psc := trace.SpanContextFromContext(parameters.ParentContext) | ||
| > ``` | ||
| > | ||
| > Pass `psc.TraceState()` through when you build your `SamplingResult`. |
Contributor
Author
There was a problem hiding this comment.
@tiffany76 @open-telemetry/go-approvers et all: note the copyedits applied for this alert. Let me know if you are ok with them.
Contributor
Author
There was a problem hiding this comment.
For context, the original alert prose was added via:
vitorvasc
approved these changes
Apr 15, 2026
Contributor
Author
|
Thanks @vitorvasc.
Will merge now. Feedback is still welcome. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alertshortcode calls.markdownlint-cli2.yamland keeps it disabled in the root.markdownlint.yamlwith a short commentcontent/enthroughcontent/en/.markdownlint.yamlscripts/_md-rules/prefer-blockquote-vs-docsy-alerts/README.mdwith a link to Hugo’s escaping documentationtest:local-toolsnpm script, documents it in site docs.test:compound-tests