Refactor spec/semconv integration workflows: extract pick-branch helper#9682
Merged
chalin merged 2 commits intoopen-telemetry:mainfrom Apr 20, 2026
Merged
Conversation
otelbot-docs
bot
added
the
missing:docs-approval
chalin
commented
Apr 18, 2026
| export PR=<ID OF THE PR>; gh pr checks ${PR} --watch && gh pr merge ${PR} --squash | ||
| ``` | ||
|
|
||
| ## Specification PRs and integration branches {#spec-integration-branches} |
Contributor
Author
There was a problem hiding this comment.
@carlosalberto and @open-telemetry/specs-approvers, this is a writeup of what to do before publishing a release. Is this clear & helpful? See the section for "Spec / semconv SIG maintainers". Feedback welcome. For a preview, see https://deploy-preview-9682--opentelemetry.netlify.app/docs/contributing/sig-practices/#spec-integration-branches
Contributor
Author
There was a problem hiding this comment.
Merging now, but feedback is still welcome.
chalin
force-pushed
the
chalin-m24-fix-spec-upd-action-2026-0418
branch
from
bafa692 to
d55641d
Compare
- Extracts the inline bash that picks the next integration version into a
shared, testable Node helper at `scripts/gh/specs/pick-branch/`.
- Selects the upstream spec via `--spec=otel|semconv`; both
`update-spec-integration-branch.yml` and
`update-semconv-integration-branch.yml` now call the same helper.
- Auto-selects dry-run vs write mode based on `GITHUB_ACTIONS`; flags
`--dry-run` / `--no-dry-run` override. Prints a `[mode]` banner
explaining its choice and the picked VERSION/BRANCH.
- Opens a deduplicated tracking issue (label `<slug>-integration-warning`)
when the helper detects problems such as stale integration branches;
adds `issues: write` permission to both workflows.
- Aligns the semconv workflow with the spec workflow by adding an
`env: { REPO, ABBR }` block and using `${{ env.REPO }}`/`${{ env.ABBR }}`
in the submodule and PR-creation steps.
- Renames the workflow step from "Set environment variables" to
"Pick integration branch".
- Adds 78 unit tests across `version`, `format`, `issue`, and `cli-args`
test files; covers the version pipeline, output formatting, issue
dedup/creation, and CLI argument parsing.
- Documents the setup under `content/en/site/build/ci-workflows.md`
(Comms-SIG perspective) and adds release-time guidance for spec /
semconv SIG maintainers under `content/en/docs/contributing/sig-practices.md`.
- Drive-by: promotes "Merging PRs" to a top-level heading in
`sig-practices.md`, adds `linkTitle: PR checks & tests` to
`pr-checks.md`.
chalin
force-pushed
the
chalin-m24-fix-spec-upd-action-2026-0418
branch
from
d55641d to
49c9b9e
Compare
theletterf
approved these changes
Apr 20, 2026
otelbot-docs
bot
added
ready-to-be-merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/gh/specs/pick-branch/.--spec=otel|semconv; bothupdate-spec-integration-branch.ymlandupdate-semconv-integration-branch.ymlnow call the same helper.GITHUB_ACTIONS; flags--dry-run/--no-dry-runoverride. Prints a[mode]banner explaining its choice and the picked VERSION/BRANCH.<slug>-integration-warning) when the helper detects problems such as stale integration branches; addsissues: writepermission to both workflows.env: { REPO, ABBR }block and using${{ env.REPO }}/${{ env.ABBR }}in the submodule and PR-creation steps.version,format,issue, andcli-argstest files; covers the version pipeline, output formatting, issue dedup/creation, and CLI argument parsing.content/en/site/build/ci-workflows.md(Comms-SIG perspective) and adds release-time guidance for spec / semconv SIG maintainers undercontent/en/docs/contributing/sig-practices.md.sig-practices.md, addslinkTitle: PR checks & teststopr-checks.md./cc @vitorvasc @carlosalberto
Preview: