Add windows and macos platforms to CI#383
Merged
nvictus merged 14 commits intoopen2c:masterfrom Feb 2, 2024
Merged
Conversation
nvictus
force-pushed
the
ci-windows-macos-tests
branch
from
a8df777 to
4555f77
Compare
nvictus
force-pushed
the
ci-windows-macos-tests
branch
from
b8da49c to
b3de9cf
Compare
nvictus
force-pushed
the
ci-windows-macos-tests
branch
2 times, most recently
from
ae2e3dd to
11ede46
Compare
nvictus
force-pushed
the
ci-windows-macos-tests
branch
from
11ede46 to
a91c1a7
Compare
See issues with NamedTemporaryFile on Windows: https://docs.python.org/3.12/library/tempfile.html#tempfile.NamedTemporaryFile
nvictus
force-pushed
the
ci-windows-macos-tests
branch
from
0037dac to
21eb456
Compare
thomas-reimonn
approved these changes
Feb 2, 2024
Contributor
thomas-reimonn
left a comment
thomas-reimonn
left a comment
There was a problem hiding this comment.
This looks great! I see it running on windows, Mac and ubuntu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pypairix,pysam) platform-dependentNamedTemporaryFileon Windows to allow re-opening (see Python docs for more info).