Reduce memory consumption of very high-resolution merges#408
Merged
nvictus merged 7 commits intoopen2c:masterfrom Mar 23, 2024
Merged
Reduce memory consumption of very high-resolution merges#408nvictus merged 7 commits intoopen2c:masterfrom
nvictus merged 7 commits intoopen2c:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a high memory consumption issue when a large number of very high resolution coolers are merged. It should improve the performance not only of
cooler mergebut also ofcooler cload pairsandcooler load.In pre-calculating offsets to use for the merge execution plan, we were loading (and concatenating) all
bin1_offsetindexes into memory. This isn't an issue for typical coolers, but can become prohibitively large for many inputs at high resolutions, where a single index vector can be ~2GB in size at human 10bp resolution.bin1_offsetindex incrementally during merge execution planning. This results in a drastic improvement for merges involving e.g. 100s of datasets.cooler cload pairsandcooler load, and the max-merge option tocooler load, to give the user more flexibility in controlling maximum memory consumption during the actual merge epochs.