You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi all,
updated the codebase to work with numpy 2.x .
Also had a look at the CI – the current CI failure seems to be caused by pypairix breaking on compile, commenting the dependency out makes it run. Have submitted an issue there and propose adding it again when that is fixed.
Currently, some test cases in test_cli_ingest.py and test_create_ingest.py are returning different values than stored in tests/data.
Not sure what's causing that, as the numpy update shouldn't change behaviour in this way. Might be the missing pypairix dependency, or an earlier change that wasn't noticed due to the general CI failure?
In a local pipeline using cooler I don't see any changes, so I think this should be fine to merge anyways, though it would be nice to get CI passing.
Cheers and happy winter holidays,
Leon
The test errors were actually caused by a strange behavioral change starting in numpy 2.1. Applying np.array() to a pandas Series no longer produces a proper copy of the data even when copy=True. As a result, some in-place operations on the array were mutating the underlying dataframe. This seems like a bug, though perhaps numpy's semantics of "shallow" copying have changed.
I switched to the pandas method Series.to_numpy(copy=True), which guarantees a true copy.
the current CI failure seems to be caused by pypairix breaking on compile, commenting the dependency out makes it run. Have submitted an issue there and propose adding it again when that is fixed.
I agree with dropping pairix from the [all] extra until a fix is released. FWIW, this PR seems to resolve the compilation issue, at least for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
updated the codebase to work with numpy 2.x .
Also had a look at the CI – the current CI failure seems to be caused by pypairix breaking on compile, commenting the dependency out makes it run. Have submitted an issue there and propose adding it again when that is fixed.
Currently, some test cases in
test_cli_ingest.pyandtest_create_ingest.pyare returning different values than stored intests/data.Not sure what's causing that, as the numpy update shouldn't change behaviour in this way. Might be the missing pypairix dependency, or an earlier change that wasn't noticed due to the general CI failure?
In a local pipeline using cooler I don't see any changes, so I think this should be fine to merge anyways, though it would be nice to get CI passing.
Cheers and happy winter holidays,
Leon