Fixed indexing in merge_breakpoints#468
Merged
conradbzura merged 6 commits intoopen2c:masterfrom Jul 21, 2025
Merged
Conversation
conradbzura
force-pushed
the
conrad/#466
branch
2 times, most recently
from
359f430 to
3a7553e
Compare
nvictus
reviewed
Jul 16, 2025
nvictus
approved these changes
Jul 16, 2025
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugging issue #466 using the provided data set, I observed that the first iteration here appends a value of 0 to
cum_nrecords, indicating an off-by-one-error because the next value in combined_index is 29162134. My proposed fix resolves the error, but it would be good to have someone confirm that the output is valid.