Skip to content

remove auxiliary audio extension#1021

Merged
jongwook merged 2 commits intoopenai:mainfrom
ain-soph:main
Mar 7, 2023
Merged

remove auxiliary audio extension#1021
jongwook merged 2 commits intoopenai:mainfrom
ain-soph:main

Conversation

@ain-soph
Copy link
Copy Markdown
Contributor

@ain-soph ain-soph commented Mar 3, 2023

Old:
'./abc.wav' -> './abc.wav.srt'

New:
'./abc.wav' -> './abc.srt'

@jongwook
Copy link
Copy Markdown
Collaborator

jongwook commented Mar 6, 2023

Thanks. This is a breaking change but I think it makes sense and will be more compatible to more tools that expect the same basename and different extension

@jongwook jongwook merged commit c6e4e5e into openai:main Mar 7, 2023
zackees pushed a commit to zackees/whisper that referenced this pull request May 5, 2023
Co-authored-by: Jong Wook Kim <jongwook@openai.com>
leejuyuu added a commit to leejuyuu/try-whisper-in-google-collab that referenced this pull request May 15, 2023
Whisper had a breaking change that changes the output extension in
openai/whisper#1021.
This makes the Colab notebook not working.
Fix this by changing the file names.
ilanit1997 pushed a commit to ilanit1997/whisper that referenced this pull request May 16, 2023
Co-authored-by: Jong Wook Kim <jongwook@openai.com>
abyesilyurt pushed a commit to abyesilyurt/whisper that referenced this pull request Nov 13, 2023
Co-authored-by: Jong Wook Kim <jongwook@openai.com>
heejipark23 pushed a commit to heejipark23/whisper that referenced this pull request Sep 21, 2025
Co-authored-by: Jong Wook Kim <jongwook@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants