Skip to content

[Repo Assist] perf: replace List.Insert(0) with LinkedList.AddFirst in NotificationHistoryService #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
+3 −3
Closed

[Repo Assist] perf: replace List.Insert(0) with LinkedList.AddFirst in NotificationHistoryService #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/OpenClaw.Tray.WinUI/Services/NotificationHistoryService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ namespace OpenClawTray.Services;
/// </summary>
public static class NotificationHistoryService
{
private static readonly List<NotificationHistoryItem> _history = new();
private static readonly LinkedList<NotificationHistoryItem> _history = new();
private static readonly object _lock = new();
private const int MaxHistory = 100;

public static void AddNotification(GatewayNotification notification)
{
lock (_lock)
{
_history.Insert(0, new NotificationHistoryItem
_history.AddFirst(new NotificationHistoryItem
{
Timestamp = DateTime.Now,
Title = notification.Title ?? "OpenClaw",
Expand All @@ -29,7 +29,7 @@ public static void AddNotification(GatewayNotification notification)
// Trim to max
while (_history.Count > MaxHistory)
{
_history.RemoveAt(_history.Count - 1);
_history.RemoveLast();
}
}
}
Expand Down
⚡