[Repo Assist] improve: extract FormatAge into ModelFormatting, removing duplicate logic#154
Merged
shanselman merged 1 commit intomasterfrom Apr 8, 2026
Conversation
…logic GatewayNodeInfo and SessionInfo both implemented identical age-formatting logic (just now / Xm ago / Xh ago / Xd ago). Consolidate into a single ModelFormatting.FormatAge(DateTime) helper. - Add ModelFormatting.FormatAge(DateTime timestampUtc) - SessionInfo.AgeText now delegates to ModelFormatting.FormatAge - GatewayNodeInfo.FormatAge now delegates to ModelFormatting.FormatAge - No behaviour change; all existing tests pass (525 Shared, 99 Tray) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
GatewayNodeInfoandSessionInfoboth implemented identical age-formatting logic independently:This PR extracts that logic into a single
ModelFormatting.FormatAge(DateTime)helper, consistent with the existingModelFormatting.FormatLargeNumberpattern.Changes
ModelFormatting— newFormatAge(DateTime timestampUtc)methodSessionInfo.AgeText— delegates toModelFormatting.FormatAge(UpdatedAt ?? LastSeen)GatewayNodeInfo.FormatAge— delegates toModelFormatting.FormatAge(timestampUtc)No behaviour change. Future age-formatting tweaks (e.g. adding weeks, locale) now only need one edit.
Test Status
SessionInfoAgeTextTestsandGatewayNodeInfoTests.DetailText_LastSeen_*tests pass unchanged, confirming no behaviour regression.