Skip to content

dnn(onnx): test data for quantized layers support pr #28543#1319

Open
shahkarnav115-beep wants to merge 4 commits intoopencv:5.xfrom
shahkarnav115-beep:qlinearconv-dynamic-opencv
Open

dnn(onnx): test data for quantized layers support pr #28543#1319
shahkarnav115-beep wants to merge 4 commits intoopencv:5.xfrom
shahkarnav115-beep:qlinearconv-dynamic-opencv

Conversation

@shahkarnav115-beep
Copy link
Copy Markdown

The pr has 6 files with one mobilenetv2-12-qdq.onnx, it was added to check if now qdq model runs on new engine or not.

Related: opencv/opencv#28543

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please use existing image from OpenCV Extra as test image. No need to add a new one.
  2. Please add the code you used to generate ONNX models with https://github.com/opencv/opencv_extra/blob/4.x/testdata/dnn/onnx/generate_quantized_onnx_models.py. Or, better, reuse existing ONNX files.

@shahkarnav115-beep
Copy link
Copy Markdown
Author

@asmorkalov I am working on the code part to generate the given .onnx files, I will commit the changes shortly.

@shahkarnav115-beep
Copy link
Copy Markdown
Author

@asmorkalov I have added code to generate the 4 specific models (single_qgemm, single_qlinearadd, single_qlinearconv, single_qpool). The mobilenetv2-12-qdq.onn was downloaded from huggingface,

link: https://huggingface.co/onnxmodelzoo/mobilenetv2-12/tree/main

@asmorkalov asmorkalov changed the title dnn(onnx): file data used in pr #28543 dnn(onnx): test data for quantized layers support pr #28543 Feb 24, 2026
@asmorkalov
Copy link
Copy Markdown
Contributor

No need to put imagenet_classes.txt into repo. Please remove classes file loading and add assertion with class index check. There are several classification tests in OpenCV, please use the same approach for result validation as other tests.

@asmorkalov
Copy link
Copy Markdown
Contributor

Please do not put mobilenetv2-12-qdq.onnx into repo, but extend https://github.com/opencv/opencv_extra/blob/4.x/testdata/dnn/download_models.py#L1234 with proper model link. Please use the original HuggingFace link, but not own forks or copies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants