Open
Conversation
6 tasks
abhishek-gola
pushed a commit
to abhishek-gola/opencv
that referenced
this pull request
Mar 20, 2026
DNN: Fix Squeeze to remove all size-1 dims when axes is empty opencv#28425 Fixes opencv#28424 OpenCV Extra: [opencv/opencv_extra#1308](opencv/opencv_extra#1308) This PR fixes the ONNX Squeeze operator to correctly remove all size-1 dimensions when `axes` is not provided, conforming to the ONNX specification. ### Details Per [ONNX Squeeze specification](https://onnx.ai/onnx/operators/onnx__Squeeze.html): > 'If axes is not provided, all the single dimensions will be removed from the shape.' Previously, OpenCV DNN would not remove any dimensions in this case, causing shape mismatch errors with models like LaMa (inpainting). ### Example ```python # Input: [1, 1, 2, 4] # Squeeze with no axes attribute # Before: [1, 1, 2, 4] ✗ (No change) # After: [2, 4] ✓ (matches ONNX Runtime) ``` ### Tests Added `testONNXModels("squeeze_no_axes")` which validates this behavior with new test data. opencv_extra_pr=opencv/opencv_extra#1324 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch (4.x for bug fixes) - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable - Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
omrope79
force-pushed
the
caffe-importer-cleanup
branch
from
c9f5c86 to
f72cd85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the required test data (models/blobs) for PR opencv/opencv#28678.