Skip to content

chore(ci): add GHCR login as a part of Build and Release#101

Merged
mittachaitu merged 4 commits intoopenebs-archive:developfrom
niladrih:ghcr
Sep 7, 2021
Merged

chore(ci): add GHCR login as a part of Build and Release#101
mittachaitu merged 4 commits intoopenebs-archive:developfrom
niladrih:ghcr

Conversation

@niladrih
Copy link
Copy Markdown
Member

@niladrih niladrih commented Sep 7, 2021

Signed-off-by: Niladri Halder niladri.halder@mayadata.io

Why is this PR required? What issue does it fix?:
This adds GHCR login steps in build.yml and release.yml workflows

Signed-off-by: Niladri Halder <niladri.halder@mayadata.io>
@niladrih niladrih requested a review from kmova September 7, 2021 06:46
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #101 (7fd77a3) into develop (08f7183) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #101   +/-   ##
========================================
  Coverage    46.97%   46.97%           
========================================
  Files           29       29           
  Lines         2378     2378           
========================================
  Hits          1117     1117           
  Misses        1182     1182           
  Partials        79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f7183...7fd77a3. Read the comment docs.

Signed-off-by: Niladri Halder <niladri.halder@mayadata.io>
@kmova kmova requested review from mittachaitu and mynktl September 7, 2021 12:45
Copy link
Copy Markdown
Contributor

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Niladri Halder <niladri.halder@mayadata.io>
Signed-off-by: Niladri Halder <niladri.halder@mayadata.io>
@mittachaitu mittachaitu merged commit e5b789c into openebs-archive:develop Sep 7, 2021
@niladrih niladrih deleted the ghcr branch September 7, 2021 15:40
niladrih added a commit to niladrih/dynamic-nfs-provisioner that referenced this pull request Sep 7, 2021
…hive#101)

* Add GHCR login as a part of Build and Release

* Modify test to log PVC obj and extend retry threshold

Signed-off-by: Niladri Halder <niladri.halder@mayadata.io>
@niladrih niladrih mentioned this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants