chore(backendPvcTimeout): option to configure BackendPvcTimeout using env Var#84
Merged
mittachaitu merged 4 commits intoopenebs-archive:developfrom Aug 13, 2021
Merged
Conversation
added 3 commits
August 9, 2021 19:41
… OPENEBS_IO_NFS_SERVER_BACKEND_PVC_TIMEOUT Signed-off-by: mayank <mayank.patel@mayadata.io>
Signed-off-by: mayank <mayank.patel@mayadata.io>
Signed-off-by: mayank <mayank.patel@mayadata.io>
kmova
reviewed
Aug 13, 2021
| # value: "true" | ||
| # Set Timeout for backend PVC to bound, Default value is 60 seconds | ||
| #- name: OPENEBS_IO_NFS_SERVER_BACKEND_PVC_TIMEOUT | ||
| # value: "120" |
Collaborator
There was a problem hiding this comment.
n_: set this as 60 to match the default value.
kmova
reviewed
Aug 13, 2021
kmova
approved these changes
Aug 13, 2021
mittachaitu
reviewed
Aug 13, 2021
Contributor
mittachaitu
left a comment
mittachaitu
left a comment
There was a problem hiding this comment.
comment on a log... rest of the changes looks good to me
Signed-off-by: mayank <mayank.patel@mayadata.io>
mynktl
force-pushed
the
backend_pvc_timeout
branch
from
54bb979 to
bf5642f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #84 +/- ##
===========================================
- Coverage 46.99% 46.85% -0.14%
===========================================
Files 29 29
Lines 2349 2356 +7
===========================================
Hits 1104 1104
- Misses 1167 1174 +7
Partials 78 78
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does?:
This PR adds an option to configure BackendPvcTimeout.
OPENEBS_IO_NFS_SERVER_BACKEND_PVC_TIMEOUTcan be set to configure BackendPvcTimeout in nfs-provisioner deployment.Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Checklist:
<type>(<scope>): <subject>