Skip to content

chore(cherry-pick): For PR 89...92, 94, 98#99

Merged
mittachaitu merged 6 commits intov0.6.xfrom
develop
Aug 30, 2021
Merged

chore(cherry-pick): For PR 89...92, 94, 98#99
mittachaitu merged 6 commits intov0.6.xfrom
develop

Conversation

@mynktl
Copy link
Copy Markdown
Contributor

@mynktl mynktl commented Aug 30, 2021

Why is this PR required? What issue does it fix?:

What this PR does?:
This PR cherry-picks commits from branch develop to v0.6.x.

Followings PRs are added for cherry-picking:
#89
#90
#91
#92
#94
#98

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Does this PR change require updating NFS-Provisioner Chart? If yes, mention the Helm Chart PR #
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

mynktl and others added 6 commits August 16, 2021 23:05
…orageclass is having invalid topology (#90)


Signed-off-by: mayank <mayank.patel@mayadata.io>
…oner (#89)

This PR adds resources requests and limits values after
monitoring nfs-provisioner behavior during the idle and busy time.

Steps performed to monitor:
Noted the values of CPU & memory usage after applying nfs-provisioner
YAML. Provisioned 50 NFS-PVCs, 100 NFS-PVCs at a time and collected the
memory & CPU usage of the nfs-provisioner periodically.

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
* chore(helm-chart): chart release for v0.6.0

Signed-off-by: mayank <mayank.patel@mayadata.io>
…FS Server (#92)

This PR adds support to configure resource requirements[requests & limits]
for NFS Server via NFS StorageClass. Values specified in StorageClass annotation
will be propagated to NFS Server deployment.

**Sample NFS SC YAML**:
```yaml
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: openebs-rwx
  annotations:
    openebs.io/cas-type: nfsrwx
    cas.openebs.io/config: |
      - name: NFSServerType
        value: "kernel"
      - name: BackendStorageClass
        value: "openebs-hostpath"
      #  NFSServerResourceRequests defines the resource requests for NFS Server
      - name: NFSServerResourceRequests
        value: |-
            memory: 50Mi
            cpu: 50m
      #  NFSServerResourceLimits defines the resource limits for NFS Server
      - name: NFSServerResourceLimits
        value: |-
            memory: 100Mi
            cpu: 100m
provisioner: openebs.io/nfsrwx
reclaimPolicy: Delete
```

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Signed-off-by: mayank <mayank.patel@mayadata.io>
- sigs.k8s.io/sig-storage-lib-external-provisioner to v7.0.1
- Kubernetes dependencies to v0.20.2
- kolg to v2.10.0
- This commit updates the kubernetes version from 1.17 to 1.18 in intro.md

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
@mynktl mynktl requested review from kmova and mittachaitu August 30, 2021 12:22
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #99 (ab20fd2) into v0.6.x (bab5c4e) will increase coverage by 0.11%.
The diff coverage is 37.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.6.x      #99      +/-   ##
==========================================
+ Coverage   46.85%   46.97%   +0.11%     
==========================================
  Files          29       29              
  Lines        2356     2378      +22     
==========================================
+ Hits         1104     1117      +13     
- Misses       1174     1182       +8     
- Partials       78       79       +1     
Impacted Files Coverage Δ
...kg/kubernetes/api/apps/v1/deployment/kubernetes.go 0.00% <0.00%> (ø)
provisioner/controller.go 0.00% <0.00%> (ø)
provisioner/provisioner.go 0.00% <0.00%> (ø)
provisioner/provisioner_kernel_nfs_server.go 0.00% <0.00%> (ø)
provisioner/signal_handler.go 0.00% <0.00%> (ø)
...es/api/core/v1/persistentvolumeclaim/kubernetes.go 67.44% <10.00%> (ø)
...ernetes/api/core/v1/persistentvolume/kubernetes.go 65.07% <14.28%> (ø)
pkg/kubernetes/api/core/v1/namespace/kubernetes.go 72.54% <20.00%> (ø)
provisioner/config.go 12.19% <37.50%> (+12.19%) ⬆️
provisioner/helper_kernel_nfs_server.go 79.63% <90.00%> (-0.44%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab5c4e...ab20fd2. Read the comment docs.

Copy link
Copy Markdown
Contributor

@mittachaitu mittachaitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants