Skip to content

feat(bdd): adding bdd test cases for LVM Driver#26

Merged
akhilerm merged 2 commits intoopenebs:masterfrom
pawanpraka1:bdd
Mar 3, 2021
Merged

feat(bdd): adding bdd test cases for LVM Driver#26
akhilerm merged 2 commits intoopenebs:masterfrom
pawanpraka1:bdd

Conversation

@pawanpraka1
Copy link
Copy Markdown
Contributor

@pawanpraka1 pawanpraka1 commented Feb 22, 2021

Signed-off-by: Pawan pawan@mayadata.io

Why is this PR required? What issue does it fix?:

adding bdd test case for LVM Driver. test cases added are

  1. volume creation/deletion
  2. snapshot creation
  3. block volume creation/deletion
  4. application pod creation/deletion
  5. resize volume

@pawanpraka1 pawanpraka1 changed the title feat(bdd): adding bdd test case for LVM Driver feat(bdd): adding bdd test cases for LVM Driver Feb 22, 2021
@pawanpraka1 pawanpraka1 force-pushed the bdd branch 12 times, most recently from 7be6d46 to 47fe7ef Compare February 22, 2021 15:55
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments:

  1. builder code can be moved from tests/ to pkg/builder
  2. Test to check , volume resize is not done, if a snapshot exists

@pawanpraka1 pawanpraka1 force-pushed the bdd branch 3 times, most recently from 7a2ecf6 to 189299d Compare March 1, 2021 12:44
@pawanpraka1 pawanpraka1 force-pushed the bdd branch 5 times, most recently from 9393dd2 to 80b3d2e Compare March 1, 2021 14:47
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #26 (80b3d2e) into master (7effd08) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #26   +/-   ##
======================================
  Coverage    1.20%   1.20%           
======================================
  Files          11      11           
  Lines         830     830           
======================================
  Hits           10      10           
  Misses        820     820           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7effd08...80b3d2e. Read the comment docs.

@pawanpraka1
Copy link
Copy Markdown
Contributor Author

@akhilerm I have raise a separate PR(#27) for moving the bdd test cases to github action, also have added test case to do the resize if snapshot is there.

@pawanpraka1 pawanpraka1 added this to the v0.3 milestone Mar 3, 2021
Signed-off-by: Pawan <pawan@mayadata.io>
Signed-off-by: Pawan <pawan@mayadata.io>
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhilerm akhilerm merged commit a7c1102 into openebs:master Mar 3, 2021
@pawanpraka1 pawanpraka1 deleted the bdd branch May 19, 2021 13:31
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.06%. Comparing base (755f4c3) to head (cd77bbe).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #26   +/-   ##
======================================
  Coverage    4.06%   4.06%           
======================================
  Files          15      15           
  Lines        1229    1229           
======================================
  Hits           50      50           
  Misses       1170    1170           
  Partials        9       9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants