fix(chart): revert env OPENEBS_NAMESPACE to LVM_NAMESPACE for v1.6.x#333
Merged
niladrih merged 1 commit intoopenebs:developfrom Sep 19, 2024
Merged
fix(chart): revert env OPENEBS_NAMESPACE to LVM_NAMESPACE for v1.6.x#333niladrih merged 1 commit intoopenebs:developfrom
niladrih merged 1 commit intoopenebs:developfrom
Conversation
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
requested review from
Abhinandan-Purkait,
abhilashshetty04,
avishnu,
dsharma-dc,
tiagolobocastro and
w3aman
avishnu
reviewed
Sep 19, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #333 +/- ##
===========================================
- Coverage 98.66% 97.95% -0.71%
===========================================
Files 2 2
Lines 673 784 +111
===========================================
+ Hits 664 768 +104
- Misses 5 9 +4
- Partials 4 7 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
avishnu
approved these changes
Sep 19, 2024
w3aman
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The env LVM_NAMESPACE was changed to OPENEBS_NAMESPACE on the develop branch as a part of #324. This change breaks v1.6.x.
Need to investigate if it breaks develop as well.