Skip to content

build: update CSI sidecars in-line with zfs#452

Open
tiagolobocastro wants to merge 1 commit intodevelopfrom
csi
Open

build: update CSI sidecars in-line with zfs#452
tiagolobocastro wants to merge 1 commit intodevelopfrom
csi

Conversation

@tiagolobocastro
Copy link
Copy Markdown
Member

What this PR does?: update CSI sidecars in-line with zfs

Any additional information for your reviewer? :

A previous attempt had failed because the snapshot support was not ready.

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

A previous attempt had failed because the snapshot support was not ready.

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
Copy link
Copy Markdown
Member Author

2026-02-11T13:50:10.8682947Z �[1mSTEP�[0m: Creating Pv
2026-02-11T13:50:10.9239940Z Command 'sudo pvcreate /dev/loop1' succeeded with stderr output:
2026-02-11T13:50:10.9241014Z WARNING: Ignoring duplicate config value: thin_pool_autoextend_threshold
2026-02-11T13:50:10.9241873Z WARNING: Ignoring duplicate config value: thin_pool_autoextend_percent

The thin_pool_autoextend_threshold is duplicated, so I think the changes made may be incorrect? CC @rohan2794

@abhilashshetty04
Copy link
Copy Markdown
Member

@tiagolobocastro ,

Warning is not causing the test to fail but there is a duplicate config.

admin@ubuntu-32gb-fsn1-1-abhilash:~$ cat /etc/lvm/lvm.conf | grep thin_pool_autoextend
        # Configuration option activation/thin_pool_autoextend_threshold.
        # Also see thin_pool_autoextend_percent.
        thin_pool_autoextend_threshold = 50
        thin_pool_autoextend_threshold = 50
        # Configuration option activation/thin_pool_autoextend_percent.
        thin_pool_autoextend_percent = 20
        thin_pool_autoextend_percent = 20

The failure is due to volumesnapshot READYTOUSE field being set as false. Test expects it to be true. We have seen this last time while we were updating CSI spec.

admin@ubuntu-32gb-fsn1-1-abhilash:~$ kubectl get vs -n openebs
NAME         READYTOUSE   SOURCEPVC   SOURCESNAPSHOTCONTENT   RESTORESIZE   SNAPSHOTCLASS     SNAPSHOTCONTENT                                    CREATIONTIME   AGE
lvmpv-snap   false        lvmpv-pvc                                         lvmpv-snapclass   snapcontent-6f9c092d-6fd3-4a7b-a5b2-eb71ea44d383                  42s

@rohan2794 can you please have look at this.

@rohan2794
Copy link
Copy Markdown
Contributor

rohan2794 commented Apr 3, 2026

@tiagolobocastro ,

Warning is not causing the test to fail but there is a duplicate config.

admin@ubuntu-32gb-fsn1-1-abhilash:~$ cat /etc/lvm/lvm.conf | grep thin_pool_autoextend
        # Configuration option activation/thin_pool_autoextend_threshold.
        # Also see thin_pool_autoextend_percent.
        thin_pool_autoextend_threshold = 50
        thin_pool_autoextend_threshold = 50
        # Configuration option activation/thin_pool_autoextend_percent.
        thin_pool_autoextend_percent = 20
        thin_pool_autoextend_percent = 20

The failure is due to volumesnapshot READYTOUSE field being set as false. Test expects it to be true. We have seen this last time while we were updating CSI spec.

admin@ubuntu-32gb-fsn1-1-abhilash:~$ kubectl get vs -n openebs
NAME         READYTOUSE   SOURCEPVC   SOURCESNAPSHOTCONTENT   RESTORESIZE   SNAPSHOTCLASS     SNAPSHOTCONTENT                                    CREATIONTIME   AGE
lvmpv-snap   false        lvmpv-pvc                                         lvmpv-snapclass   snapcontent-6f9c092d-6fd3-4a7b-a5b2-eb71ea44d383                  42s

@rohan2794 can you please have look at this.

@tiagolobocastro @abhilashshetty04 fix PR for duplicate warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants