🥅 Validate volume readiness before mount#258
Merged
mergify[bot] merged 1 commit intoopenebs:developfrom Nov 30, 2025
Merged
Conversation
Contributor
🧪 CI InsightsHere's what we observed from your CI run for f1b7fcb. 🟢 All jobs passed!But CI Insights is watching 👀 |
mhkarimi1383
force-pushed
the
validate-vol-readiness
branch
2 times, most recently
from
eaf0207 to
d9e2664
Compare
Member
tiagolobocastro
left a comment
tiagolobocastro
left a comment
There was a problem hiding this comment.
This shouldn't be possible, how can a not ready volume be staged?
Are we completing the CreateVolume call before the volume is ready?
Member
Author
|
@tiagolobocastro I have added this for safety, These functions will not get called when volumes are not ready |
tiagolobocastro
approved these changes
Nov 30, 2025
Member
Author
|
@mergify rebase |
Signed-off-by: Muhammed Hussain Karimi <info@karimi.dev>
Contributor
✅ Branch has been successfully rebased |
mhkarimi1383
force-pushed
the
validate-vol-readiness
branch
from
d9e2664 to
f1b7fcb
Compare
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 024a44a |
Contributor
Merge Queue Status
✅ The pull request has been merged This pull request spent 19 minutes 11 seconds in the queue, including 19 minutes 6 seconds waiting for CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.