[ecovacs] Fix device definition for T50 PRO OMNI#20017
Merged
jlaur merged 1 commit intoopenhab:mainfrom Jan 11, 2026
Merged
Conversation
Unlike the T30, this device uses the custom water amount feature. It also was misdetected as T30S. Fixes openhab#19482 Signed-off-by: Danny Baumann <dannybaumann@web.de>
Contributor
Author
|
Once accepted, please also backport to 5.1.x. I'm actually not sure about the state of all the other T30S variants listed in the device list (whether they use custom water amount or not). I took the list largely from here, but that library doesn't have support for custom water amount in either case, and given it's JS based, it likely won't choke on the lack of water amount in the response either. |
jlaur
pushed a commit
that referenced
this pull request
Jan 11, 2026
Unlike the T30, this device uses the custom water amount feature. It also was misdetected as T30S. Fixes #19482 Signed-off-by: Danny Baumann <dannybaumann@web.de>
jlaur
added
the
backported
Merlin10437
pushed a commit
to Merlin10437/openhab-addons
that referenced
this pull request
Mar 24, 2026
Unlike the T30, this device uses the custom water amount feature. It also was misdetected as T30S. Fixes openhab#19482 Signed-off-by: Danny Baumann <dannybaumann@web.de> Signed-off-by: Merlin10437 <152161717+Merlin10437@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike the T30, this device uses the custom water amount feature. It also was misdetected as T30S.
Fixes #19482