[roku] Refactor discovery to use UPnP#20090
Merged
lsiepel merged 4 commits intoopenhab:mainfrom Jan 24, 2026
Merged
Conversation
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
mlobstein
added
the
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Roku binding's discovery mechanism from a custom SSDP implementation to use the framework's built-in UPnP discovery infrastructure. This significantly reduces code complexity by replacing a 272-line custom discovery service with a 119-line UPnP discovery participant.
Changes:
- Replaced RokuDiscoveryService with RokuDiscoveryParticipant that implements UpnpDiscoveryParticipant interface
- Added openhab-transport-upnp dependency to feature.xml
- Updated README documentation to reflect UPnP usage and improve consistency
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| RokuDiscoveryService.java | Removed custom SSDP-based discovery implementation |
| RokuDiscoveryParticipant.java | Added new UPnP-based discovery participant |
| feature.xml | Added openhab-transport-upnp feature dependency |
| README.md | Updated discovery documentation from SSDP to UPnP and improved consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Merlin10437
pushed a commit
to Merlin10437/openhab-addons
that referenced
this pull request
Mar 24, 2026
* Refactor discovery to use UPnP Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Merlin10437 <152161717+Merlin10437@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the Roku discovery service to use internal UPnP discovery rather than a dedicated SSDP implementation. I don't remember why I didn't do this originally... Perhaps only because the Roku ECP documentation details low level SSDP discovery techniques. But this PR now accomplishes the same thing with half as much code.