[shelly] Fix "duplicate id" in device log#20092
Closed
markus7017 wants to merge 2 commits intoopenhab:mainfrom
Closed
[shelly] Fix "duplicate id" in device log#20092markus7017 wants to merge 2 commits intoopenhab:mainfrom
markus7017 wants to merge 2 commits intoopenhab:mainfrom
Conversation
Signed-off-by: Markus Michels <markus7017@gmail.com>
markus7017
added
the
bug
requested id includes "ohshelly-<id>-<request id>" Signed-off-by: Markus Michels <markus7017@gmail.com>
Contributor
Author
|
inconsistent PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the generation of RPC message.src and message.id to avoid "duplicate id" messages in the device log cause by overlapping http requests. In addition message.jsonrpc will be set to "2.0" according to the latest API spec.
@Nadahar I'm starting to carve-out self-contained PRs from the mDNS one to make merging easier (and in fact the changes here do are not in scope of mDNS fixing)