Skip to content

[bluelink] Support setting AC/DC charge limits#20663

Merged
lsiepel merged 2 commits intoopenhab:mainfrom
florian-h05:bluelink-charge-limits
May 4, 2026
Merged

[bluelink] Support setting AC/DC charge limits#20663
lsiepel merged 2 commits intoopenhab:mainfrom
florian-h05:bluelink-charge-limits

Conversation

@florian-h05
Copy link
Copy Markdown
Contributor

  • Make the AC & DC charge limit channels writeable.
  • Add Thing actions to set charge limits.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@openhab-bot
Copy link
Copy Markdown
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/bluelink-binding-hyundai-kia-genesis-5-0-0-0-5-2-0-0/167623/22

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR exposes Bluelink's existing AC/DC charge-limit APIs through the binding so users can set charge targets from writable channels and Thing actions. It extends the vehicle-side command flow, bridge wrapper methods, metadata, and documentation for the new control surface.

Changes:

  • Make the charge-limit-ac and charge-limit-dc vehicle channels writable and disable auto-update for them.
  • Add vehicle Thing actions for setting AC/DC charge limits, plus the handler/account plumbing to forward those requests.
  • Document the new actions/channel capabilities and add WireMock coverage for the EU account API path.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
bundles/org.openhab.binding.bluelink/src/test/java/org/openhab/binding/bluelink/internal/handler/BluelinkAccountHandlerTest.java Adds EU WireMock tests for AC/DC charge-limit API requests.
bundles/org.openhab.binding.bluelink/src/main/resources/OH-INF/thing/vehicle.xml Makes the AC/DC charge-limit channels writable and sets auto-update veto.
bundles/org.openhab.binding.bluelink/src/main/resources/OH-INF/i18n/bluelink.properties Adds i18n labels for the new charge-limit actions and inputs.
bundles/org.openhab.binding.bluelink/src/main/java/org/openhab/binding/bluelink/internal/handler/VehicleActions.java Adds rule actions and static helpers for setting AC/DC charge limits.
bundles/org.openhab.binding.bluelink/src/main/java/org/openhab/binding/bluelink/internal/handler/BluelinkVehicleHandler.java Handles writable channel commands and adds vehicle-level charge-limit methods.
bundles/org.openhab.binding.bluelink/src/main/java/org/openhab/binding/bluelink/internal/handler/BluelinkAccountHandler.java Adds account-handler pass-through methods for AC/DC charge-limit calls.
bundles/org.openhab.binding.bluelink/README.md Documents the new actions and marks the charge-limit channels as read/write.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bundles/org.openhab.binding.bluelink/src/main/resources/OH-INF/thing/vehicle.xml Outdated
Comment thread bundles/org.openhab.binding.bluelink/src/main/resources/OH-INF/thing/vehicle.xml Outdated
Comment thread bundles/org.openhab.binding.bluelink/README.md Outdated
Comment thread bundles/org.openhab.binding.bluelink/README.md Outdated
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label May 4, 2026
@lsiepel
Copy link
Copy Markdown
Contributor

lsiepel commented May 4, 2026

Somehow i manually had to approve the workflow, thought that was only needed for first time contributors. anyway, the DCO is also complaining :-/

Please comment on the review comments that have been resolved (or not)

@florian-h05
Copy link
Copy Markdown
Contributor Author

I've addressed all Copilot comments.
Or more exactly: My AI agent did that, unfortunately Git in the agent's sandbox is not signing off.
As the agent is using its own GitHub account to push (and only using my name), that might also explain why you had to approve the PR runs.

@florian-h05
Copy link
Copy Markdown
Contributor Author

@lsiepel Adressed Copilot review and forced DCO to pass - the sign off is only missing from the second commit, it’s done for the first and so it will get added to the merge message.

Copy link
Copy Markdown
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 205dfe3 into openhab:main May 4, 2026
2 checks passed
@lsiepel lsiepel added this to the 5.2 milestone May 4, 2026
@florian-h05 florian-h05 deleted the bluelink-charge-limits branch May 4, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants