[bluelink] Support setting AC/DC charge limits#20663
Conversation
florian-h05
commented
May 3, 2026
- Make the AC & DC charge limit channels writeable.
- Add Thing actions to set charge limits.
Signed-off-by: Florian Hotze <dev@florianhotze.com>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/bluelink-binding-hyundai-kia-genesis-5-0-0-0-5-2-0-0/167623/22 |
There was a problem hiding this comment.
Pull request overview
This PR exposes Bluelink's existing AC/DC charge-limit APIs through the binding so users can set charge targets from writable channels and Thing actions. It extends the vehicle-side command flow, bridge wrapper methods, metadata, and documentation for the new control surface.
Changes:
- Make the
charge-limit-acandcharge-limit-dcvehicle channels writable and disable auto-update for them. - Add vehicle Thing actions for setting AC/DC charge limits, plus the handler/account plumbing to forward those requests.
- Document the new actions/channel capabilities and add WireMock coverage for the EU account API path.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
bundles/org.openhab.binding.bluelink/src/test/java/org/openhab/binding/bluelink/internal/handler/BluelinkAccountHandlerTest.java |
Adds EU WireMock tests for AC/DC charge-limit API requests. |
bundles/org.openhab.binding.bluelink/src/main/resources/OH-INF/thing/vehicle.xml |
Makes the AC/DC charge-limit channels writable and sets auto-update veto. |
bundles/org.openhab.binding.bluelink/src/main/resources/OH-INF/i18n/bluelink.properties |
Adds i18n labels for the new charge-limit actions and inputs. |
bundles/org.openhab.binding.bluelink/src/main/java/org/openhab/binding/bluelink/internal/handler/VehicleActions.java |
Adds rule actions and static helpers for setting AC/DC charge limits. |
bundles/org.openhab.binding.bluelink/src/main/java/org/openhab/binding/bluelink/internal/handler/BluelinkVehicleHandler.java |
Handles writable channel commands and adds vehicle-level charge-limit methods. |
bundles/org.openhab.binding.bluelink/src/main/java/org/openhab/binding/bluelink/internal/handler/BluelinkAccountHandler.java |
Adds account-handler pass-through methods for AC/DC charge-limit calls. |
bundles/org.openhab.binding.bluelink/README.md |
Documents the new actions and marks the charge-limit channels as read/write. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Somehow i manually had to approve the workflow, thought that was only needed for first time contributors. anyway, the DCO is also complaining :-/ Please comment on the review comments that have been resolved (or not) |
|
I've addressed all Copilot comments. |
|
@lsiepel Adressed Copilot review and forced DCO to pass - the sign off is only missing from the second commit, it’s done for the first and so it will get added to the merge message. |