Skip to content

refactor(pricelist): switch from ID-based to UUID-based pricelist fet…#58

Open
delcroip wants to merge 1 commit into
developfrom
feature/fix-prices
Open

refactor(pricelist): switch from ID-based to UUID-based pricelist fet…#58
delcroip wants to merge 1 commit into
developfrom
feature/fix-prices

Conversation

@delcroip

Copy link
Copy Markdown
Member

…ching

Replace formatNodeQuery with formatPageQuery using UUID filters for fetching services and items pricelists. Update navigation in detail pages to use UUID-based routing instead of numeric IDs, passing pricelist data via history state to avoid redundant fetches. Add normalizePrice helper to sanitize price overrule values before mutation. Migrate components from class-based Redux (connect/bindActionCreators) to hooks (useDispatch/ useSelector) for consistency.

#Thank you for your contribution to openIMIS!
#Please complete the sections below. Anything in comments is guidance and can be deleted.

Description

A clear, concise description of the change. Why is it needed? What problem does it solve?

Type of Change

  • Feature
  • Bug fix
  • Chore (Refactor, Docs, CI/CD)
  • Other, please specify

Related Issue(s) / Task(s)

  • Requires [link to github PR], [link to github PR] needs to be merged first before this one
  • Relates to [link to github PR], this needs to be merged before [link to github PR]
  • External reference (e.g., Jira):

Demo

Upload screenshots/gifs or link to any demo video here.

Checklist

  • Unit tests added/modified
  • I18n / translation handled

…ching

Replace `formatNodeQuery` with `formatPageQuery` using UUID filters for
fetching services and items pricelists. Update navigation in detail pages
to use UUID-based routing instead of numeric IDs, passing pricelist data
via history state to avoid redundant fetches. Add `normalizePrice` helper
to sanitize price overrule values before mutation. Migrate components from
class-based Redux (`connect`/`bindActionCreators`) to hooks (`useDispatch`/
`useSelector`) for consistency.

@mngoe mngoe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We install this version and it seems to work as expected.
openimis/openimis-fe-claim_js#264

Will do a second round of functionnal testing on a business perspective.

A new PR has just been done to fix module installation : openimis/openimis-fe-claim_js#264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants