Skip to content

Fix Jackson 2.21+ compatibility for JREThrowableFinalMethods #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 1 commit into from
Mar 16, 2026
Merged

Fix Jackson 2.21+ compatibility for JREThrowableFinalMethods #1010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/main/java/org/openrewrite/java/migrate/JREThrowableFinalMethods.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@
package org.openrewrite.java.migrate;

import com.fasterxml.jackson.annotation.JsonCreator;
import lombok.AccessLevel;
import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.RequiredArgsConstructor;
import org.jspecify.annotations.Nullable;
import org.openrewrite.ExecutionContext;
import org.openrewrite.Preconditions;
import org.openrewrite.Recipe;
Expand All @@ -33,16 +32,19 @@
import org.openrewrite.java.tree.TypeUtils;

@EqualsAndHashCode(callSuper = false)
@RequiredArgsConstructor(access = AccessLevel.PACKAGE)
public class JREThrowableFinalMethods extends Recipe {

private final String methodPatternAddSuppressed;
private final String methodPatternGetSuppressed;

@JsonCreator
public JREThrowableFinalMethods() {
this.methodPatternAddSuppressed = "*..* addSuppressed(Throwable)";
this.methodPatternGetSuppressed = "*..* getSuppressed()";
public JREThrowableFinalMethods(
@Nullable String methodPatternAddSuppressed,
@Nullable String methodPatternGetSuppressed) {
this.methodPatternAddSuppressed = methodPatternAddSuppressed == null ?
"*..* addSuppressed(Throwable)" : methodPatternAddSuppressed;
this.methodPatternGetSuppressed = methodPatternGetSuppressed == null ?
"*..* getSuppressed()" : methodPatternGetSuppressed;
}

@Getter
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/openrewrite/java/migrate/JREThrowableFinalMethodsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ void methodUsingException(ThrowableWithIllegalOverrrides t1) {
void shouldRenameOnJava6() {
//language=java
rewriteRun(
spec -> spec.recipe(new JREThrowableFinalMethods()),
spec -> spec.recipe(new JREThrowableFinalMethods(null, null)),
java(
"""
class ClassUsingThrowable {
Expand All @@ -118,7 +118,7 @@ void methodUsingRenamedMethodsAlready(Throwable t1) {
void shouldNotRenameOnJava7() {
//language=java
rewriteRun(
spec -> spec.recipe(new JREThrowableFinalMethods()),
spec -> spec.recipe(new JREThrowableFinalMethods(null, null)),
java(
"""
class ClassUsingThrowable {
Expand Down
Loading
⚡