Document null-probing semantic differences in singleton migrations#1081
Merged
Document null-probing semantic differences in singleton migrations#1081
Conversation
`List.of(..)`, `Set.of(..)`, and `Map.of(..)` throw `NullPointerException` when probed with `contains(null)` and friends, whereas the `Collections.singleton*` factories return `false`/`-1`/`null`. Call this out in each recipe description so users can decide whether the migration is safe for their code. Also fixes a `Set.Of` typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MigrateCollectionsSingletonListchangescontains(null)semantics #1079.List.of(..),Set.of(..), andMap.of(..)throwNullPointerExceptionwhen probed withcontains(null)and friends, whereas theCollections.singleton*factories returnfalse/-1/null. The semantic difference is undecidable across method boundaries (the reporter's case has the probe happen in downstream code), so rather than make the rewrite conditional, this PR calls out the divergence in each recipe description so users can decide whether the migration is safe for their code.Also fixes a
Set.Of→Set.oftypo in theMigrateCollectionsSingletonSetdescription.