Keep parentheses when renaming typed lambda parameter to underscore#1082
Merged
Keep parentheses when renaming typed lambda parameter to underscore#1082
Conversation
A single explicitly typed lambda parameter like `(RequestContext rc) -> ...` must remain parenthesized after renaming to `_`, otherwise the resulting `RequestContext _ -> ...` is invalid Java. Fixes #1080
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ReplaceUnusedVariablesWithUnderscoreproducing invalid Java for explicitly typed single-parameter lambdas:(RequestContext rc) -> ...was being unparenthesized toRequestContext _ -> ...Only drop the parentheses when the single parameter has no explicit type expression
Add regression test mirroring the issue's reproducer
Fixes ReplaceUnusedVariablesWithUnderscore produces invalid syntax for typed lambda parameters #1080
Test plan
./gradlew test --tests ReplaceUnusedVariablesWithUnderscoreTestpasses