Fix Kotlin tests after K2 compiler upgrade#940
Merged
Conversation
Remove .+ version suffixes from KotlinParser.classpathFromResources() calls so the K2 compiler's version stripping regex (-\d+$) can properly resolve JAR files. Affects 4 test files with Kotlin parser configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KotlinParser.Builder.classpathFromResources()strips version suffixes with regex-\d+$but version patterns with.+(e.g.,"spring-beans-5.+") don't match the regex and fail to resolve on the runtime classpath.Changes
Removes
.+suffixes from KotlinParser classpath version patterns:NoAutowiredOnConstructorTest:"spring-beans-5.+"→"spring-beans-5", etc. (4 names)ImplicitWebAnnotationNamesTest:"spring-web-5.+"→"spring-web-5"DatabaseComponentAndBeanInitializationOrderingTest: 4 version patterns updatedSimplifyWebTestClientCallsTest:"spring-web-6.+","spring-test-6.+"→ remove.+JavaParser calls remain unchanged (still use
dependenciesFromResources).Test Plan
Run the previously failing Kotlin tests:
./gradlew test --tests "NoAutowiredOnConstructorTest"./gradlew test --tests "ImplicitWebAnnotationNamesTest"./gradlew test --tests "DatabaseComponentAndBeanInitializationOrderingTest"./gradlew test --tests "SimplifyWebTestClientCallsTest.replaceKotlinInt"