Skip meta-annotated @Configuration in FinalClass and HideUtilityClassConstructor#867
Merged
Skip meta-annotated @Configuration in FinalClass and HideUtilityClassConstructor#867
@Configuration in FinalClass and HideUtilityClassConstructor#867Conversation
…ClassConstructor` Enables meta-annotation matching so classes annotated with `@TestConfiguration`, `@SpringBootApplication`, and any user-defined stereotype layered on top of `@Configuration` are also skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flip the
AnnotationMatcherfor@org.springframework.context.annotation.ConfigurationtomatchesMetaAnnotations=truein bothFinalClassVisitorandHideUtilityClassConstructorVisitor, so classes annotated with@TestConfiguration,@SpringBootApplication, or any other stereotype layered on top of@Configurationare skipped for the same proxy/CGLIB reasons.Add regression tests covering
@TestConfigurationfor both recipes.Addresses
FinalClassandHideUtilityClassConstructorshould not apply for Spring Configuration classes #729 (comment).Test plan
./gradlew test --tests FinalClassTest --tests HideUtilityClassConstructorTest