Fix UpdateMavenModel using stale projectPoms for child module resolution (#7307) (#7310)

When UpdateMavenModel re-resolved a POM after XML changes (e.g. parent
version bump), the projectPoms map was built from the original marker
hierarchy and still contained the old requested Pom. Child modules
resolved recursively would therefore look up the stale root Pom and
inherit dependency management from the old grandparent.

Update the projectPoms map with the current requested Pom before passing
it to updateResult(), so recursive child resolution sees the updated
parent reference.

Author: timtebeek

rewrite-maven/src/main/java/org/openrewrite/maven/UpdateMavenModel.java

@@ -139,8 +139,13 @@ public Xml visitDocument(Xml.Document document, P p) {
         }
 
         try {
+            Map<Path, Pom> projectPoms = resolutionResult.getProjectPoms();
+            Path sourcePath = requested.getSourcePath();
+            if (sourcePath != null) {
+                projectPoms.put(sourcePath, requested);
+            }
             MavenResolutionResult updated = updateResult(ctx, resolutionResult.withPom(resolutionResult.getPom().withRequested(requested)),
-                    resolutionResult.getProjectPoms());
+                    projectPoms);
             return document.withMarkers(document.getMarkers().computeByType(getResolutionResult(),
                     (original, ignored) -> updated));
         } catch (MavenDownloadingExceptions e) {

rewrite-maven/src/test/java/org/openrewrite/maven/ChangeParentPomTest.java

@@ -2429,7 +2429,15 @@ void submoduleParentModelDependencyManagementUpdated() {
                       </parent>
                     </project>
                     """,
-                    spec -> spec.path("pom.xml")
+                    spec -> spec.path("pom.xml").afterRecipe(doc -> {
+                        MavenResolutionResult result = doc.getMarkers().findFirst(MavenResolutionResult.class).orElseThrow();
+                        // Root's modules should also have updated dependency management
+                        assertThat(result.getModules()).isNotEmpty();
+                        MavenResolutionResult childModule = result.getModules().get(0);
+                        assertThat(childModule.getPom().getDependencyManagement())
+                            .describedAs("Root's child module should have new junit 6.0.1 entries in dependency management")
+                            .anyMatch(dep -> dep.getGav().toString().equals("org.junit.jupiter:junit-jupiter:6.0.1"));
+                    })
                 ),
                 mavenProject(
                     "sample-rest",
@@ -2474,6 +2482,13 @@ void submoduleParentModelDependencyManagementUpdated() {
                             assertThat(result.getParent().getPom().getDependencyManagement())
                                 .describedAs("Parent's dependency management should contain new junit 6.0.1 entries")
                                 .anyMatch(dep -> dep.getGav().toString().equals("org.junit.jupiter:junit-jupiter:6.0.1"));
+                            // Verify child's own resolved dependency management reflects the new grandparent
+                            assertThat(result.getPom().getDependencyManagement())
+                                .describedAs("Child's own dependency management should not contain old junit 5.10.3 entries")
+                                .noneMatch(dep -> dep.getGav().toString().equals("org.junit.jupiter:junit-jupiter:5.10.3"));
+                            assertThat(result.getPom().getDependencyManagement())
+                                .describedAs("Child's own dependency management should contain new junit 6.0.1 entries")
+                                .anyMatch(dep -> dep.getGav().toString().equals("org.junit.jupiter:junit-jupiter:6.0.1"));
                         })
                     )
                 )