Fix UpdateMavenModel using stale projectPoms for child module resolution#7310
Merged
Fix UpdateMavenModel using stale projectPoms for child module resolution#7310
Conversation
…ion (#7307) When UpdateMavenModel re-resolved a POM after XML changes (e.g. parent version bump), the projectPoms map was built from the original marker hierarchy and still contained the old requested Pom. Child modules resolved recursively would therefore look up the stale root Pom and inherit dependency management from the old grandparent. Update the projectPoms map with the current requested Pom before passing it to updateResult(), so recursive child resolution sees the updated parent reference.
steve-aom-elliott
approved these changes
Apr 7, 2026
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
sambsnyd
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateMavenModelre-resolved a POM after XML changes (e.g. a parent version bump byChangeParentPom), theprojectPomsmap was built from the original marker hierarchy and still contained the old requested PomprojectPomsmap with the currentrequestedPom before passing it toupdateResult()Test plan
submoduleParentModelDependencyManagementUpdatedtest to verify the child's own resolved dependency management and the root's module list both reflect the new grandparentChangeParentPomTestsuite passesAddDependencyTestandRemoveRedundantDependencyVersionsTestpass