Revert "Don't close process.getInputStream() on failure (#6541)" (#6542)

This reverts commit 5087896.

Author: greg-at-moderne

rewrite-core/src/main/java/org/openrewrite/internal/StringUtils.java

@@ -221,22 +221,6 @@ public static String readFully(InputStream inputStream, Charset charset) {
         }
     }
 
-    public static String readFullyWithoutClosing(InputStream is, Charset charset) {
-        try {
-            ByteArrayOutputStream bos = new ByteArrayOutputStream();
-            byte[] buffer = new byte[4096];
-            int n;
-            while ((n = is.read(buffer)) != -1) {
-                bos.write(buffer, 0, n);
-            }
-
-            byte[] bytes = bos.toByteArray();
-            return new String(bytes, charset);
-        } catch (IOException e) {
-            throw new UnsupportedOperationException(e);
-        }
-    }
-
     public static String capitalize(String value) {
         if (value.isEmpty()) {
             return value;

rewrite-core/src/main/java/org/openrewrite/rpc/RewriteRpcProcess.java

@@ -34,15 +34,13 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.UncheckedIOException;
-import java.nio.charset.StandardCharsets;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.LinkedHashMap;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
 
 import static org.openrewrite.internal.StringUtils.readFully;
-import static org.openrewrite.internal.StringUtils.readFullyWithoutClosing;
 
 /**
  * A client for spawning and communicating with a subprocess that implements Rewrite RPC.
@@ -97,16 +95,18 @@ public void run() {
     public @Nullable RuntimeException getLivenessCheck() {
         if (process != null && !process.isAlive()) {
             int exitCode = process.exitValue();
-            String message = "JavaScript RPC process shut down early with exit code " + exitCode;
-
             String errorOutput = "", stdOutput = "";
-            try {
-                errorOutput = readFullyWithoutClosing(process.getErrorStream(), StandardCharsets.UTF_8);
-                stdOutput = readFullyWithoutClosing(process.getInputStream(), StandardCharsets.UTF_8);
-            } catch (UnsupportedOperationException e) {
-                message += "\nError retrieving output/error stream: " + e.getMessage();
+
+            // Read any remaining output from the process
+            try (InputStream errorStream = process.getErrorStream();
+                 InputStream inputStream = process.getInputStream()) {
+                errorOutput = readFully(errorStream);
+                stdOutput = readFully(inputStream);
+            } catch (IOException | UnsupportedOperationException e) {
+                // Ignore errors reading final output
             }
 
+            String message = "JavaScript RPC process shut down early with exit code " + exitCode;
             if (!stdOutput.isEmpty()) {
                 message += "\nStandard output:\n  " + stdOutput.replace("\n", "\n  ");
             }