RPC - Don't close process.getInputStream() on failure#6541
Merged
greg-at-moderne merged 1 commit intomainfrom Jan 15, 2026
Merged
RPC - Don't close process.getInputStream() on failure#6541greg-at-moderne merged 1 commit intomainfrom
greg-at-moderne merged 1 commit intomainfrom
Conversation
greg-at-moderne
added a commit
that referenced
this pull request
Jan 15, 2026
This reverts commit 5087896.
greg-at-moderne
added a commit
that referenced
this pull request
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Slightly changing the handling of unhappy path in the RPC framework.
Namely, when printing out stdout and stderr in case of errors, don't close the input streams.
Also adding slightly more defensive reporting of errors.
What's your motivation?
Make a step towards understanding the random failures of RPC in tests manifesting themselves as: