Reduce the size of the match string in TextMatches data table

[knutwannheden]

When a pattern is matched against a very long line, the result in the data table is now truncated to include at most 50 characters before and 50 characters after the match of that line.

[sambsnyd]

Perhaps this should be configurable? Sometimes you might want long matches

[MBoegers]

I the context size is now optional configurable. The default is 0 leading to just the matched text in the Datatable.
With -1 the truncate can be deactivated and the full text is in the Datatable, as on main currently for whoever uses this.

[MBoegers]

Is it necessary to have the Search marker inside the Match text in the Datatable? if we add StartMatch and EndMatch we could have the same data without the strange looking ~~>

EDIT: this would break existing logic and looks like not a good idea at this point.

[github-actions]

Some suggestions could not be made:

• rewrite-core/src/main/java/org/openrewrite/text/Find.java
  • lines 21-21

[timtebeek]

Copying the failure here: new test expectation not updated it seems.

RewriteRpcTest > runRecipe() FAILED
    java.lang.AssertionError: 
    Expecting ArrayList:
      [TextMatches.Row(sourcePath=hello.txt, match=...~~>Hello...)]
    to contain:
      [TextMatches.Row(sourcePath=hello.txt, match=~~>Hello Jon!)]
    but could not find the following element(s):
      [TextMatches.Row(sourcePath=hello.txt, match=~~>Hello Jon!)]
        at org.openrewrite.rpc.RewriteRpcTest.lambda$runRecipe$4(RewriteRpcTest.java:137)
        at org.openrewrite.rpc.RewriteRpcTest$$Lambda$1088/0x00007f9e4040bbc8.acceptThrows(Unknown Source)
        at org.openrewrite.test.UncheckedConsumer.accept(UncheckedConsumer.java:27)
        at org.openrewrite.test.RecipeSpec.lambda$dataTable$5(RecipeSpec.java:213)
        at org.openrewrite.test.RecipeSpec$$Lambda$833/0x00007f9e40319458.acceptThrows(Unknown Source)
        at org.openrewrite.test.UncheckedConsumer.accept(UncheckedConsumer.java:27)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:388)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:130)
        at org.openrewrite.rpc.RewriteRpcTest.runRecipe(RewriteRpcTest.java:131)

[timtebeek]

Please keep an eye out for downstream changes needed after these types of changes as well:

• openrewrite/rewrite-docker@e7b3d83

[timtebeek]

We have a recipe that's able to add these nullable arguments as needed:
https://app.moderne.io/recipes/org.openrewrite.java.AddNullMethodArgument#defaults=W3sibmFtZSI6Im1ldGhvZFBhdHRlcm4iLCJ2YWx1ZSI6Im9yZy5vcGVucmV3cml0ZS50ZXh0LkZpbmQgPGNvbnN0cnVjdG9yPihTdHJpbmcsIEJvb2xlYW4sIEJvb2xlYW4sIEJvb2xlYW4sIEJvb2xlYW4sIFN0cmluZywgQm9vbGVhbikifSx7Im5hbWUiOiJhcmd1bWVudEluZGV4IiwidmFsdWUiOiI3In0seyJuYW1lIjoicGFyYW1ldGVyVHlwZSIsInZhbHVlIjoiamF2YS5sYW5nLkludGVnZXIifSx7Im5hbWUiOiJwYXJhbWV0ZXJOYW1lIiwidmFsdWUiOiJjb250ZXh0U2l6ZSJ9XQ==