Conversation
9b61b8b to
a33a494
Compare
|
It would be most ideal that the FieldAccess and Identifier cases were able to specify the full class name via type attribution. Unfortunately, the types weren't available even after adding the OpenRewrite plugin to the classpath. I didn't feel comfortable either with forcing the class name in from either value due to the possibility of all other kinds of code combinations that could arise from real world usage. TODOs:
|
|
I think this is awesome! |
| void alias() { | ||
| rewriteRun( | ||
| spec -> spec.recipe(RewriteTest.toRecipe(() -> new GradlePlugin.Matcher().asVisitor(plugin -> SearchResult.found(plugin.getTree())))), | ||
| toml( |
There was a problem hiding this comment.
Wondering if we should have a gradleVersionCatalog() or similar.
There was a problem hiding this comment.
Definitely a good candidate for a potential helper method. The default file name that is picked up automatically by Gradle is gradle/libs.versions.toml, so we'd probably align in some capacity to that if we chose to adopt such a helper.
What's changed?
Added a trait implementing to find direct and transitive Gradle plugins and relevant information about them.
What's your motivation?
More traits? 😆
Anything in particular you'd like reviewers to focus on?
Nothing in particular
Anyone you would like to review specifically?
Anybody.
Have you considered any alternatives or workarounds?
N/A
Any additional context
Checklist