Added additional tests for nested annotations, and a fix to break out of the J.Assignment for finding an annotation parent that is more significant when the nearest desired parent is a not a J.ClassDeclaration#5724
Conversation
… of the `J.Assignment` for finding an annotation parent that is more significant when the nearest desired parent is a not a `J.ClassDeclaration`
knutwannheden
approved these changes
Jul 7, 2025
Contributor
knutwannheden
left a comment
There was a problem hiding this comment.
Good to have even more supported cases. Did we already have any issue for this?
Contributor
Author
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnnotationTemplateGeneratordoes not handle nested annotations correctly #5712AnnotationTemplateGeneratorto handle nested annotations correctly #5713 to fix case when the nearest desired parent isn't aJ.ClassDeclarationand your wrapping annotation uses aJ.Assignmentfor theJ.NewArrayrather than just a rawJ.NewArray.Checklist