Skip to content

Added additional tests for nested annotations, and a fix to break out of the J.Assignment for finding an annotation parent that is more significant when the nearest desired parent is a not a J.ClassDeclaration#5724

Merged
timtebeek merged 1 commit intomainfrom
fix-annotation-template-generator-for-nested-on-method
Jul 8, 2025

Conversation

@steve-aom-elliott
Copy link
Copy Markdown
Contributor

@steve-aom-elliott steve-aom-elliott commented Jul 7, 2025

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

… of the `J.Assignment` for finding an annotation parent that is more significant when the nearest desired parent is a not a `J.ClassDeclaration`
@steve-aom-elliott steve-aom-elliott self-assigned this Jul 7, 2025
@steve-aom-elliott steve-aom-elliott added bug Something isn't working test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail labels Jul 7, 2025
@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite Jul 7, 2025
@steve-aom-elliott steve-aom-elliott moved this from In Progress to Ready to Review in OpenRewrite Jul 7, 2025
Copy link
Copy Markdown
Contributor

@knutwannheden knutwannheden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have even more supported cases. Did we already have any issue for this?

@timtebeek timtebeek merged commit 4c870fa into main Jul 8, 2025
2 checks passed
@timtebeek timtebeek deleted the fix-annotation-template-generator-for-nested-on-method branch July 8, 2025 07:17
@github-project-automation github-project-automation Bot moved this from Ready to Review to Done in OpenRewrite Jul 8, 2025
@steve-aom-elliott
Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working test provided Already replicated with a unit test, using JUnit pioneer's ExpectedToFail

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants